Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new deploySmartContract() API, reworked getHederaNativeIDFromEVMaddress API logic, reworked HEDERA_SMART_CONTRACTS_ASSETS constant logic(#303) #306

Conversation

quiet-node
Copy link
Member

Description: This PR adds new PR and reworked API logics

  • New deploySmartContract() API
  • getHederaNativeIDFromEVMaddress() can now dynamically querying both accountId and contractId
  • HEDERA_SMART_CONTRACTS_ASSETS constant is now an object instead of array

Related issue(s): #279

Fixes #303

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
- dynamically query accountId and contractId
- unit tests

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node requested a review from a team as a code owner August 8, 2023 20:11
@quiet-node quiet-node self-assigned this Aug 8, 2023
@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Aug 8, 2023
@quiet-node quiet-node added this to the 0.5.0 milestone Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Test Results

197 tests  ±0   191 ✔️ ±0   6m 44s ⏱️ +2s
  62 suites ±0       6 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit d06f296. ± Comparison against base commit ba59453.

@quiet-node quiet-node merged commit 7e408a4 into main Aug 9, 2023
16 checks passed
@quiet-node quiet-node deleted the 303-Add-new-deploySmartContract()-API-and-rework-getHederaNativeIDFromEvmAddress()-API-logic branch August 9, 2023 03:09
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
…FromEVMaddress API logic, reworked HEDERA_SMART_CONTRACTS_ASSETS constant logic(hashgraph#303) (hashgraph#306)

* dapp-update: reworked HEDERA_SMART_CONTRACTS_ASSETS constant logic

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

* dapp-feat: added new deploySmartContract() API and its unit test

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

* dapp-update: reworked getHederaNativeIDFromEvmAddress() logic

- dynamically query accountId and contractId
- unit tests

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

---------

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Tooling tooling
Projects
None yet
2 participants