Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

95 Add stable equals/hashCode for PBJ objects #109

Merged
merged 10 commits into from
Nov 22, 2023
Merged

95 Add stable equals/hashCode for PBJ objects #109

merged 10 commits into from
Nov 22, 2023

Commits on Nov 20, 2023

  1. Implement stable hashCode for record fields. 

    Cleaned up some code.
Add equals method implementation.
Added tests and benchmarks for hashCode and equals

This is a fix for issue #95.

Signed-off-by: Lubomir Litchev <lubomir@swirldslabs.com>
Co-authored-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    Lubomir Litchev and imalygin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    6becef8 View commit details
    Browse the repository at this point in the history

  2. Clean up 

    Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ee7e91e View commit details
    Browse the repository at this point in the history

  3. Fixed generated code indentation. Removed code duplication. Replaced … 

    …adding spaced with `.indent` calls.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    abb4574 View commit details
    Browse the repository at this point in the history

  4. Addressed Artem's comment. 

    Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    dfa400b View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin @codacy-production
    imalygin and codacy-production[bot] committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7c69529 View commit details
    Browse the repository at this point in the history

  6. Addressed review comments. 

    Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    921e6c6 View commit details
    Browse the repository at this point in the history

  7. Added patch from Jasper. Addressed Jasper's comments. Changed generat… 

    …ed code directory layout to match Maven.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e21de96 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Addressed review comments. 

    Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cfb554d View commit details
    Browse the repository at this point in the history

  2. Addressed review comments. 

    Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    52376d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Addressed review comments. 

    Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
    @imalygin
    imalygin committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    df696c8 View commit details
    Browse the repository at this point in the history