fix: 27: ReadableStreamingData should implement bulk read methods #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
artemananiev
requested review from
jasperpotts,
imalygin,
rbair23,
OlegMazurov and
jsync-swirlds
JUnit Test Report 45 files + 2 45 suites +2 3m 30s ⏱️ -36s Results for commit 8d3754f. ± Comparison against base commit 4aa8a08. This pull request removes 3 and adds 26 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/stream/ReadableStreamingData.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/stream/ReadableStreamingData.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/stream/ReadableStreamingData.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/stream/ReadableStreamingData.java
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/stream/ReadableStreamingData.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/test/java/com/hedera/pbj/runtime/io/ReadableSequentialTestBase.java
Outdated
Show resolved
Hide resolved
Addressed reviewers' comments Implemented one more method in WriteableStreamingData Removed some unused imports Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/stream/WritableStreamingData.java
Outdated
Show resolved
Hide resolved
Fixed WriteableStreamingData.writeBytes(ByteBuffer) and added a new unit test for it Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
jsync-swirlds
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix summary:
readBytes()methods are implemented inReadableStreamingDatain a more efficient way than inherited fromReadableSequentialDataReadableStreamingDataonly now are also used for other implementations ofReadableSequentialData(e.g.BufferedData)Fixes: #27
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com