fix: properly generate code and pass tests when protobuf message definition is empty #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition is empty Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
imalygin
approved these changes
Dec 1, 2023
|
An empty message definition is not a valid input. Why do we want to try to support that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Without this fix, when an empty protobuf definition is supplied, the generator and tests fail.
Related issue(s):
Fixes #130
Notes for reviewer:
Add an empty protobuf message to the hedera-protobufs repo, or change settings.gradle.kts to use
and run the build task on pbj-integration-tests.
See it done here: 5091ab9#diff-33c26aa8d64828ee0a21e949f86378b4702433336009b2a6575795e6416d7d29R26
Checklist