Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from Flow.Subscriber to Pipeline #325

Conversation

rbair23
Copy link
Member

@rbair23 rbair23 commented Nov 15, 2024

Change the usage from Flow.Subscriber to Pipeline

Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
@rbair23 rbair23 requested review from a team as code owners November 15, 2024 20:58
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

JUnit Test Report

   67 files  ±0     67 suites  ±0   2m 33s ⏱️ +4s
1 247 tests ±0  1 244 ✅ ±0   3 💤 ±0  0 ❌ ±0 
7 102 runs  ±0  7 083 ✅ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 57ac33e. ± Comparison against base commit 383b410.

This pull request removes 8 and adds 7 tests. Note that renamed tests count towards both.
, 1
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c311be0@38929da, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c311df8@69d667a5
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31ecf0@c67395, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31ef08@5fc7255c
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31f120@61993d18, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31f338@6f240187
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312010@95cecc5, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312228@48b3b1b8
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312440@b86cb18, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312658@29c244e
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312870@6cc8da1c, [Mock for EnumWithProtoMetadata, hashCode: 859156431, Mock for EnumWithProtoMetadata, hashCode: 1523941008, Mock for EnumWithProtoMetadata, hashCode: 439636632], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312a88@574ebdaf
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8311be0@38929da, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8311df8@69d667a5
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b831ecf0@c67395, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b831ef08@5fc7255c
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b831f120@61993d18, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b831f338@6f240187
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8312010@95cecc5, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8312228@48b3b1b8
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8312440@b86cb18, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8312658@29c244e
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8312870@6cc8da1c, [Mock for EnumWithProtoMetadata, hashCode: 859156431, Mock for EnumWithProtoMetadata, hashCode: 1523941008, Mock for EnumWithProtoMetadata, hashCode: 439636632], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f21b8312a88@574ebdaf
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
, 1

Copy link

Integration Test Report

    297 files  ±0      297 suites  ±0   9m 3s ⏱️ +23s
104 157 tests ±0  104 157 ✅ ±0  0 💤 ±0  0 ❌ ±0 
104 385 runs  ±0  104 385 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 57ac33e. ± Comparison against base commit 383b410.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f585c4f7510@96f0372
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f585c4f7748@1375bbb6
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f585c4f7980@18bb642b
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f00334f8238@12932b86
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f00334f8470@13831f0d
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f00334f86a8@75953530

@rbair23 rbair23 merged commit d7c41ea into main Nov 15, 2024
10 checks passed
@rbair23 rbair23 deleted the 00323-change-from-flowsubscriber-to-pipeline-which-extends-from-flowsubscriber branch November 15, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change from Flow.Subscriber to Pipeline (which extends from Flow.Subscriber)
2 participants