Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00330 grpc-encoding does not support all valid encodings for identity #331

Conversation

rbair23
Copy link
Member

@rbair23 rbair23 commented Nov 22, 2024

Added support for additional variations of "identity" as valid encodings. Compared with the Go gRPC server for behavior. Added tests to cover these various scenarios.

Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
@rbair23 rbair23 requested review from a team as code owners November 22, 2024 20:44
@rbair23 rbair23 linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link

JUnit Test Report

   67 files  ± 0     67 suites  ±0   2m 34s ⏱️ -3s
1 265 tests +17  1 262 ✅ +19   3 💤  - 2  0 ❌ ±0 
7 120 runs  +17  7 101 ✅ +19  19 💤  - 2  0 ❌ ±0 

Results for commit 499d03f. ± Comparison against base commit 4b22019.

This pull request removes 2 and adds 18 tests. Note that renamed tests count towards both.
, 1
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [10] identity, deflate;q=0.5, gzip;q=0.1, br;q=0.1
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [1] gzip
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [1] identity
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [2] compress
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [2] identity;q=0.5
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [3] deflate
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [3] identity;
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [4] br
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [4] identity;nonsense
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ [5] gzip, deflate;q=0.5, identity;q=0.1
…

Copy link

Integration Test Report

    297 files  ±0      297 suites  ±0   8m 34s ⏱️ ±0s
104 157 tests ±0  104 157 ✅ ±0  0 💤 ±0  0 ❌ ±0 
104 385 runs  ±0  104 385 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 499d03f. ± Comparison against base commit 4b22019.

@rbair23 rbair23 merged commit d725d49 into main Nov 22, 2024
10 checks passed
@rbair23 rbair23 deleted the 00330-grpc-encoding-does-not-support-all-valid-encodings-for-identity branch November 22, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc-encoding does not support all valid encodings for "identity"
3 participants