Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command line flag to accept a values.yaml #496

Closed
edwin-greene opened this issue Aug 16, 2024 · 1 comment · Fixed by #615
Closed

Add a command line flag to accept a values.yaml #496

edwin-greene opened this issue Aug 16, 2024 · 1 comment · Fixed by #615
Assignees
Labels
Blocker Further development work cannot be done Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Requested by Stakeholder Requested by an individual or team that uses Solo

Comments

@edwin-greene
Copy link

edwin-greene commented Aug 16, 2024

Feature to Enhance

Solo command line flags and custom chart values.

Requested Enhancement

Solo has the -d flag but it requires an entire directory. To enable acceptance tests, the mirror node only needs to make some changes to the default values.yaml that Solo uses. To use Solo in a Github workflow with this change, at the moment it appears that we need to copy/paste Solo's chart directory, instead of just passing it the values we need added to the values.yaml.

The values.yaml passed on the command line should be in addition to the default values that Solo already uses, and any conflicting values should be overwritten with the command line version.

Business Need

To enable the use of Solo in a Github workflow to run mirror node acceptance tests with each PR or merge to main, the mirror node needs to change the default values in the Fullstack testing values.yaml to enable acceptance tests. We can do this by copy/pasting the entire directory into our repository (and just editing the values.yaml in our repo) but that is not a good practice. This change is needed to unblock #8513 Test acceptance tests in CI

Additional Context

No response

@edwin-greene edwin-greene added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Pending Triage New issue that needs to be triaged by the team labels Aug 16, 2024
@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Aug 21, 2024

We have a flag -values-file, it is available on:

  • solo mirror-node deploy
  • solo network deploy
  • solo relay deploy

However, it looks like with the example of solo network deploy the values file that solo generates is the last one in the list (right-most), thus, it would take precedence if there were any conflicts. So, this might need to get updated.

You can specify the '--values'/'-f' flag multiple times. The priority will be given to the last (right-most) file specified.

@jeromy-cannon jeromy-cannon added P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. and removed Pending Triage New issue that needs to be triaged by the team labels Aug 21, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Aug 21, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Aug 21, 2024
@jeromy-cannon jeromy-cannon added Requested by Stakeholder Requested by an individual or team that uses Solo Blocker Further development work cannot be done labels Aug 22, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Further development work cannot be done Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Requested by Stakeholder Requested by an individual or team that uses Solo
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants