-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating TTL'd sessions without a node #21208
base: main
Are you sure you want to change the base?
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
a6e39df
to
2954563
Compare
This is required to be able to hold cross-DC locks. Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
2954563
to
ec4d22c
Compare
Ping? |
@DanStough could you take a look or suggest a colleague who could? |
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
@jmurret could we get a review on this? |
Description
This is required to be able to hold cross-DC locks.
Testing & Reproduction steps
xh PUT :8500/v1/session/create dc==dc2 Name=foo TTL=10s 'NodeChecks:=[]' 'Node:=null'
Previously it would fail with an error, with this PR it successfully creates a TTL'd session. After a little bit the new session will correctly disappear from the
xh :8500/v1/session/list dc==dc2
output.Links
Fixes #6828.
PR Checklist