Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating TTL'd sessions without a node #21208

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kyrias
Copy link

@kyrias kyrias commented May 23, 2024

Description

This is required to be able to hold cross-DC locks.

Testing & Reproduction steps

  • Start a cluster with two datacenters, dc1 and dc2, and join a non-server node to dc1.
  • Against the client node, execute: xh PUT :8500/v1/session/create dc==dc2 Name=foo TTL=10s 'NodeChecks:=[]' 'Node:=null'

Previously it would fail with an error, with this PR it successfully creates a TTL'd session. After a little bit the new session will correctly disappear from the xh :8500/v1/session/list dc==dc2 output.

Links

Fixes #6828.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@kyrias kyrias requested a review from a team as a code owner May 23, 2024 13:23
Copy link

hashicorp-cla-app bot commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@kyrias kyrias force-pushed the session-without-node branch 2 times, most recently from a6e39df to 2954563 Compare May 24, 2024 10:03
@kyrias kyrias requested a review from a team as a code owner May 24, 2024 10:03
This is required to be able to hold cross-DC locks.

Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
@kyrias
Copy link
Author

kyrias commented Jun 7, 2024

Ping?

@svenstaro
Copy link

@DanStough could you take a look or suggest a colleague who could?

Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Aug 19, 2024
@svenstaro
Copy link

@jmurret could we get a review on this?

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acquiring locks from remote DCs fails (regression)
2 participants