use ndc-sdk for printSchemaAndCapabilities #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
approved these changes
Oct 29, 2024
BenoitRanque
commented
Oct 30, 2024
|
Fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ndc-sdk for printSchemaAndCapabilities
ndc-sdk exposes a function for this purpose.
Because that function is generic over something that implements
ConnectorSetup, which has an associated type that must implementConnector, the CLI now relies on effectively the whole connector crate.So, most code was moved to
ndc-clickhouse-core.ndc-clickhouseis mostly a shell, it imports the type that implementsConnectorSetupfromndc-clickhouse-coreand then callsdefault_mainwith it.