routes won't return Promise<Tink.template.Html> as it used to..

[postite]

 @:get("/")
@:produces("text/html")
public function index(){
	return Promise.NOISE.next(n->
	Home.render() //tink.template 
	);
}

compiles with error.
tink.core.Promise<tink.template.Html> should be tink.io.RealSource

workaround :

Home.render().toString() // works fine. 

but it shouldn't behave like this huh ?

[kevinresol]

what haxe version?

[postite]

hello kevin .
I run haxe 4.1.4

[kevinresol]

I reckon this is about transitivity.
Can you try adding @:transitive to tink.template.Html?

[postite]

@:transitive
(:public static function render():)
<div id="home" class="page">
    <p>oh!</p> 
</div> 
(:end:)

is it where @:transition should be placed ? because it's causing compiler to not compile and stays forever at "building" status . I hate when it does this...

[kevinresol]

it is for the abstract Html

[postite]

ah ! oh !

package tink.template;

import tink.HtmlString;
import tink.htmlstring.HtmlBuffer as Buf;
@:transitive
abstract Html(HtmlString) from HtmlString to HtmlString { ...

I've done this ... but no change ... I don't get what @:transitive does ... so I'm completely lost here :)

[kevinresol]

Anyway, if this problem is particular for tink_web, I suggest you use the @:html metadata instead

@:get("/")
@:html(_ -> Home.render())
public function index(){
	return Promise.NOISE;
}

[postite]

ok nice to know. It doesn't work in my case cause i'm using static extensions ( like : Home.render().withLayout().addAction(Command1).render() ) but i'll go without.
btw , your exemple doesn't not render anything. It seems This one does :

@:get("/")
@:html(_ -> views.Home.render()) // full path
public function index(){
	return Promise.NOISE.next(n->{hip:"hop"}); // need a next ! ? 
}

thx for your efforts :) .

[kevinresol]

I think this is a bug because Noise will produce empty http response but I think it should respect the html request.

[kevinresol]

Code pointer for contributors:

tink_web/src/tink/web/macros/Routing.hx

Lines 379 to 390 in 62a26b9

	case RNoise:
	macro @:pos(pos) tink.core.Promise.lift($result).next(
	function (_):tink.core.Promise<tink.web.routing.Response> {
	return new tink.http.Response.OutgoingResponse(
	new tink.http.Response.ResponseHeader(
	$statusCode,
	[new tink.http.Header.HeaderField(CONTENT_LENGTH, '0')].concat(${macro $a{headers}})
	),
	Chunk.EMPTY
	);
	}
	);