Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with event start or end out of range of current view #9

Open
RobinMillian opened this issue Apr 3, 2023 · 10 comments
Open

Comments

@RobinMillian
Copy link

When an event has a start or end attribute that falls outside the range of the current view, such as a custom view that starts on January 1, 2023 and ends on December 31, 2023, and the event itself starts on November 1, 2022 and ends on February 1, 2023, the end date of the event may be displayed as April 1, 2023. This could be because the month between the start of the event and the start of the view is being applied to the end date of the event.

@hbatalhaStch
Copy link
Owner

Thank you for reporting this, it's really appreciated.

I fixed the issue and released a patch, could you check?

@RobinMillian
Copy link
Author

Everything looks broken now
image
Before in 1.1.1 it was looking like
image

@hbatalhaStch
Copy link
Owner

hbatalhaStch commented Apr 4, 2023

Can you share the code?
Also, have you imported the css file?
Starting from v1.2.1 css has to be manually imported so it can compatible with Next.js

@guillemguerrero
Copy link

Hey, Thanks for your work! Has this issue been solved? It still happens to me, whenever I have an event that has its starting date before the initial view of the chart.

@hbatalhaStch
Copy link
Owner

@guillemguerrero yes I believe it's been solved, however, if it still happening to you could you share more details such as the version you're using and some code?

@guillemguerrero
Copy link

@hbatalhaStch To be honest, there's a possibility I'm doing something wrong. However, even by just using the example code you mentioned in StephenChou1017#260 (comment) it already happened. Right now I'm not using this exact same code but I'm still basing my component on it. I'm still working on it.

@hbatalhaStch
Copy link
Owner

@guillemguerrero could you share some code that would highlight the problem you are facing?

@hbatalhaStch
Copy link
Owner

Also keep in mind that I didn't thoroughly tested the code in StephenChou1017#260 (comment) as I use a class component instead of function when I am using the scheduler

@guillemguerrero
Copy link

@hbatalhaStch Yup, it was totally my fault... Sorry for bothering!

@hbatalhaStch
Copy link
Owner

@hbatalhaStch Yup, it was totally my fault... Sorry for bothering!

That's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants