4.x: Add additional postgresql + hibernate native-image configuration #9393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
There was a problem hiding this comment.
I would like to start using strict rules for mirroring the reflection config from graalvm-reachability-metadata for certain components:
- We only use
META-INF/native-image/groupId/artifactId/reflect-config.json - We DO NOT use
META-INF/helidon/native-image/reflection-config.json
We will maintain an exact copy of the reflection config from graalvm-reachability-metadata under META-INF/native-image/groupId/artifactId/reflect-config.json.
If the versions supported in graalvm-reachability-metadata and in Helidon are different, we may add additional reflection config.
Ideally we should find a way to use a different file to make it easy to mirror. E.g. use native-image.properties to specify an additional file.
tvallin
force-pushed
the
4.x-native-image-hibernate
branch
from
2c5a8cd
to
03965a3
Compare
...o.helidon.integrations.cdi/helidon-integrations-cdi-hibernate/reflect-config-additional.json
Show resolved
Hide resolved
romain-grecourt
previously approved these changes
Nov 14, 2024
romain-grecourt
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add reflection configuration from
reachability metadata (RM)repository to our own configuration.Now, we maintain an exact copy of R.M. configuration file named
reflect-config.json. When a dependency is updated, the corresponding configuration from R.M. will replace the current one. If the R.M. configuration does not exist, the currentreflect-config.jsonremain unchanged and we use a file namedreflect-config-additional.json. This file contains additional configuration required.Fixes #9136
Documentation
none