Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI Validation updates #9469

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

tomas-langer
Copy link
Member

  1. Moved host validation to UriValidator, as it belongs to URI specification
  2. Updated query and fragment validation
  3. Added configuration option to disable validation if desired

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…(and is part of URI specification).

The UriValidator now has methods to validate scheme, host, query, and fragment.
Path validation is retained in `UriPath`.

Added a new configuration option to disable validation of prologue for HTTP/1.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added this to the 4.1.4 milestone Nov 6, 2024
@tomas-langer tomas-langer self-assigned this Nov 6, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 6, 2024
spericas
spericas previously approved these changes Nov 6, 2024
@barchetta barchetta mentioned this pull request Nov 6, 2024
9 tasks
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit b21ae3c into helidon-io:main Nov 7, 2024
46 checks passed
@tomas-langer tomas-langer deleted the bug-uri-validation branch November 7, 2024 10:09
barchetta pushed a commit to barchetta/helidon that referenced this pull request Nov 7, 2024
* Validation of URI Query
* Moving host validation to UriValidator, as it belongs to URI concept (and is part of URI specification).
The UriValidator now has methods to validate scheme, host, query, and fragment.
Path validation is retained in `UriPath`.
Added a new configuration option to disable validation of prologue for HTTP/1.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@barchetta barchetta removed this from the 4.1.4 milestone Nov 7, 2024
barchetta added a commit that referenced this pull request Nov 8, 2024
* Validation of URI Query
* Moving host validation to UriValidator, as it belongs to URI concept (and is part of URI specification).
The UriValidator now has methods to validate scheme, host, query, and fragment.
Path validation is retained in `UriPath`.
Added a new configuration option to disable validation of prologue for HTTP/1.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Co-authored-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants