Javascript - Change .d.ts file to respect nullability?

[orta]

Hey folks, I was going through some of the d.ts files and spotted that the types don't necessarily match the nullability in the db, for example:

export interface Group {
    avatar_url?: string;
    create_time?: string;
    creator_id?: string;
    description?: string;
    edge_count?: number;
    id?: string;
    lang_tag?: string;
    max_count?: number;
    metadata?: {};
    name?: string;
    open?: boolean;
    update_time?: string;
}

vs

Which implies at least id, creator_id, name, metadata should be not marked as nullable. Is there something I am missing (e.g. partial requests etc)? If not, I can figure a way to update the .d.ts files to take this into account.

[novabyte]

@orta Thanks for the feedback. You're right I think we've been a little loose with the nullable types in the Type definition file. Would appreciate a pull request on it if you get the chance 🙏

[orta]

I've dug into this a bit, while the .d.ts generator doesn't account for whether something is optional in its code that is more of a downstream problem I believe.

The .d.ts file is generated from the swagger doc, which doesn't contain the info about the nullability of a property (and so my first attempt at looking at it in this repo isn't really enough.) we'd need to figure out how to get it represented in the json files in the nakama repo first