Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking PR for monaco #1

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Tracking PR for monaco #1

wants to merge 21 commits into from

Conversation

joneugster
Copy link
Member

@joneugster joneugster commented Jul 26, 2024

This PR keeps track of all modifications we'd like for using the vscode-lean4 with a monaco editor.

Further, there is one small fix to deal with mismatching client/server OS, but I'm not sure this would be the right fix in the extension. Therefore it's merely here for reference:

Updating everything

Here are the steps to keep these PRs and the entire project up-to-date with vscode-lean4:master. Ideally these are done from within the submodule lean4monaco/src/vscode-lean4:

  1. Synch master branch with upstream (can be done here with the github UI)
  2. On each PR linked here, rebase it to master and force-push.
  3. Then update monaco branch. For example, reset it to master, then merge all branches listed here again (e.g. in the order provided).
  4. now you can build lean4monaco
  5. you might want to update for example npm update @leanprover/infoview in lean4monaco, too.
  6. if the tests work, you can publish lean4monaco to npm, and then call npm update lean4monaco in lean4web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants