forked from leanprover/vscode-lean4
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking PR for monaco #1
Open
joneugster
wants to merge
21
commits into
master
Choose a base branch
from
monaco
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps track of all modifications we'd like for using the
vscode-lean4
with a monaco editor.Further, there is one small fix to deal with mismatching client/server OS, but I'm not sure this would be the right fix in the extension. Therefore it's merely here for reference:
Updating everything
Here are the steps to keep these PRs and the entire project up-to-date with
vscode-lean4:master
. Ideally these are done from within the submodulelean4monaco/src/vscode-lean4
:master
branch with upstream (can be done here with the github UI)master
and force-push.monaco
branch. For example, reset it tomaster
, then merge all branches listed here again (e.g. in the order provided).lean4monaco
npm update @leanprover/infoview
inlean4monaco
, too.lean4monaco
to npm, and then callnpm update lean4monaco
inlean4web
.