From faf58b7f98e2ee1f1a95b744e2ac1c3e8191ef8c Mon Sep 17 00:00:00 2001 From: Nelle Varoquaux Date: Thu, 7 Oct 2021 16:03:38 +0200 Subject: [PATCH 1/3] Added file contributors --- CONTRIBUTORS | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 CONTRIBUTORS diff --git a/CONTRIBUTORS b/CONTRIBUTORS new file mode 100644 index 00000000..05481a0f --- /dev/null +++ b/CONTRIBUTORS @@ -0,0 +1,3 @@ +Nelle Varoquaux +A. Gesine Caeur +Mozes Jacob From f6e9f9bcdea7de9696a8877d5aa19f8f737cc12d Mon Sep 17 00:00:00 2001 From: Nelle Varoquaux Date: Thu, 30 Dec 2021 11:45:54 +0100 Subject: [PATCH 2/3] FIX cleanup naming convention Used both X and X_ to point toward the same object closes #98 --- pastis/optimization/poisson_structure.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/pastis/optimization/poisson_structure.py b/pastis/optimization/poisson_structure.py index b6ca8f74..c24e04c6 100644 --- a/pastis/optimization/poisson_structure.py +++ b/pastis/optimization/poisson_structure.py @@ -252,12 +252,12 @@ def fit(self, counts): verbose=self.verbose, random_state=self.random_state) print(self.alpha_, self.beta_) - X_ = estimate_X(counts, - alpha=self.alpha_, - beta=self.beta_, - ini=X, - verbose=self.verbose, - bias=self.bias, - random_state=self.random_state, - maxiter=self.max_iter) - return X_ + X = estimate_X(counts, + alpha=self.alpha_, + beta=self.beta_, + ini=X, + verbose=self.verbose, + bias=self.bias, + random_state=self.random_state, + maxiter=self.max_iter) + return X From f33481e3a1d0bfd95e278bbe10a8d6b3c9c38605 Mon Sep 17 00:00:00 2001 From: Nelle Varoquaux Date: Thu, 30 Dec 2021 11:47:50 +0100 Subject: [PATCH 3/3] Update CONTRIBUTORS --- CONTRIBUTORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 05481a0f..8de8e678 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -1,3 +1,3 @@ Nelle Varoquaux -A. Gesine Caeur +A. Gesine Cauer Mozes Jacob