Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Messages around Fee Estimation #1644

Open
cipherzzz opened this issue Feb 29, 2024 · 2 comments
Open

Improve Error Messages around Fee Estimation #1644

cipherzzz opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
bug Unwanted or unintended logic causing harm

Comments

@cipherzzz
Copy link

cipherzzz commented Feb 29, 2024

Problem

I attempted to deploy a contract and received the following message:

Error estimating transaction fee. Response 400: Bad Request. Attempted to fetch http://localhost:3999/v2/fees/transaction and failed with the message: ""

Solution

It would be great for the API to send a better description than an empty string

Underlying Issue

The actual issue was that my contract name was too long

@cipherzzz cipherzzz added the feature Brand new functionality. New pages, workflows, endpoints, etc. label Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Feb 29, 2024
@ryanwaits
Copy link
Contributor

ryanwaits commented Feb 29, 2024

thanks for the contribution! though im not sure how much sense it makes to couple the estimateTransaction call with too much information about contract payloads, cc @janniks

reference:

export async function estimateTransaction(

@janniks
Copy link
Collaborator

janniks commented Mar 4, 2024

Hmm, yeah we should give better error messages. I'll check if the API is returning actual information.

@janniks janniks added bug Unwanted or unintended logic causing harm and removed feature Brand new functionality. New pages, workflows, endpoints, etc. labels Mar 4, 2024
@janniks janniks self-assigned this Mar 11, 2024
@janniks janniks moved this from 🆕 New to 📋 Backlog in DevTools Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted or unintended logic causing harm
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants