You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
First of all, thank you for this wonderfull and simple app. I love it.
To improve it, I propose you to change global settings for steam and coverart classes to private attribute. It will be more secure and your objects will be more strongs.
So, instead of :
publicfunction __construct()
{
// get the user's settingsglobal$settings;
// import the user's settings$this->settings = $settings;
(...)
for the constructor of this two objects, you should used :
In api/index.php, you have to call these objects with new Steam($settings) and new CoverArt($settings).
And in currentlyPlaying method of CoverArt, new Steam($this->settings) .
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
First of all, thank you for this wonderfull and simple app. I love it.
To improve it, I propose you to change global settings for
steam
andcoverart
classes to private attribute. It will be more secure and your objects will be more strongs.So, instead of :
for the constructor of this two objects, you should used :
In
api/index.php
, you have to call these objects withnew Steam($settings)
andnew CoverArt($settings)
.And in
currentlyPlaying
method ofCoverArt
,new Steam($this->settings)
.The text was updated successfully, but these errors were encountered: