New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use naming convention for event listener names #164

Open

manzt opened this issue Nov 7, 2022 · 0 comments

Member

manzt commented Nov 7, 2022 •

edited

Loading

There is no standardization of emitted event names. I'd prefer an <action>:<emitted> convention. E.g.,

let el = document.querySelector('#root');
let viewer = vizarr.createViewer(el);

viewer.on(
--  "viewStateChange",
++  "change:viewState",
  () => {
  /* ... */
});

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment