Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard interaction bug? #45

Open
panavrin opened this issue Feb 11, 2015 · 3 comments
Open

keyboard interaction bug? #45

panavrin opened this issue Feb 11, 2015 · 3 comments
Assignees
Labels

Comments

@panavrin
Copy link

For MUI key rack, note off event is not triggered while command key (Apple keyboard only) is pressed.

For example, press Command + C will make the note sustain forever until C is pressed again.

Cheers!

@hoch
Copy link
Owner

hoch commented Feb 11, 2015

What should happen when modifier keys are pressed? I thought about the possibility of playing notes with different properties. (velocity or octave, etc.)

Any suggestion?

@panavrin
Copy link
Author

Well, honestly, I liked the fact that I can sustain the note without having my finger keep pressing the key. :) In which case, it should be explicitly stated somewhere in the document (or let window users have the same feature with another key?)

On the other hand, I think it should not mapped to anything since user may want to use key for some other reasons (for example to copy (command) +c during the performance?). Or exactly opposite: user does not want other effect to happen when playing keys (command + s gives a sustained note and open "save as" popup window at the sam time?)

@hoch
Copy link
Owner

hoch commented Feb 11, 2015

I see. That's a feature then. Still the behavior should be documented and all the MUI elements are severely undocumented. (like zero documentation.)

On the other hand, I think it should not mapped to anything since user may want to use key for some other reasons (for example to copy (command) +c during the performance?

This is also a valid point. I have not tested how preventDefault() on a keyboard event will apply to the case.

@hoch hoch added the wontfix label Mar 24, 2015
@hoch hoch self-assigned this Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants