Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome, this is what's happening #158

Open
jdegger opened this issue Oct 27, 2020 · 25 comments
Open

Welcome, this is what's happening #158

jdegger opened this issue Oct 27, 2020 · 25 comments

Comments

@jdegger
Copy link
Collaborator

jdegger commented Oct 27, 2020

Asset 1@2x

Introduction

Hello everybody,

As of last night I will be helping maintaining react-native-twilio-programmable-voice. My main role will to manage incoming issues and PR's. The head maintainer @fabriziomoscon will resume active development.

In the last couple of months, it was clear that this repository needed some work done to keep up with the current Android, iOS and Twilio developments. Last week, we merged the long awaited #144 PR in order to move forward.

What is going to happen now

There are a few known problems with our current implementation. The main issues are:

  • On Android 10, we're not allowed anymore to start an activity in the background (resolution: use the Android ConnectionManager to handle this)
  • Upgrading to higher Twilio versions is hard, as the API's are very different. We still have a few major upgrade to go.

The first problem has the highest priority. It has been proposed a few times to have this repository working together with CallKeep, as it implements both iOS CallKit and Android ConnectionManager in the correct way to have this work.

Currently, @fabriziomoscon has started on finding out if we need to adopt CallKeep as a depedency or if we can apply the same methods in this repository ourselves. There has been no decision made here.

From our side, the first thing we focus on is fixing the background calling issue.

Help wanted!

We are actively looking for people who want to help. We know a few people active here have done a great effort in:

  • testing
  • creating their own Twilio voice solutions
  • merging CallKeep into this project

We are inviting you to volunteer and with our common goal. If you are available as a tester, developer or as something else, let it know in a comment here so we can make sure the workload is spread evenly across helpers.

Contributing, what can I do?

Task Description Assigned
Background calling restoration Either adopt CallKeep as a depedency or implement similar methods into this repo directly. @fabriziomoscon
Handle open PRs and Issues Make sure all PRs are tested and all issues are answered. @jdegger
Upgrade to newest Twilio SDKs Outline the changes needed first, then propose how to merge them into the repo. PRs welcome! You?
Add automated tests To improve the repo quality, we are looking for somebody to implement automatic tests You?
Create elaborate example repository The example repo will not only be great at showing how the plugin work, but also be the base for testing the library and reproducing problems. @edzh1
Backlog items / issues Any item marked as in backlog with nobody assigned can be picked up by anybody. Let me know if you want to work on this issue! You?

Current contributors

Name Commitment
@fabriziomoscon Head maintainer / active development / testing / docs
@jdegger Handling issues and PRs / testing / docs
@fmonsalvo Testing / occasional development
@benminer Unspecified help
@edzh1 Example app / tutorial including back-end example

Suggestions

If you have suggestions on how we should proceed, this issue can be used as a discussion thread.

@jdegger jdegger pinned this issue Oct 27, 2020
@jdegger
Copy link
Collaborator Author

jdegger commented Oct 27, 2020

Paging previous engaged users, please read our update 👍

@Pagebakers @gitstud @mysport12 @lonnylot @aniravi24 @fmonsalvo @enterteg @calz10 @ealexseen @benminer @liemdo @MrHertal @nSimonFR @gentleShark @vdikun

@jdegger jdegger mentioned this issue Oct 27, 2020
22 tasks
@fmonsalvo
Copy link
Contributor

Hey @jdegger I'll be glad to help! I'll be testing this PR as much as I can. I can't take a lot of responsibility since my plate is already full with other projects, but I'll be watching this repo, and try to commit as much code as my free time allows me to.

@jdegger
Copy link
Collaborator Author

jdegger commented Oct 28, 2020

@fmonsalvo sounds great! I will write down your name as a tester, if you have the occasional PR as well, of course be free to just start working on a backlog item (you don't need permission!). Anything, any help is very much appreciated.

@fmonsalvo
Copy link
Contributor

@jdegger I can quickly take issue #23 since we developed it and we've been using it for years. Should I open a PR against master directly or is all the work being done and grouped in one specific branch?

@jdegger
Copy link
Collaborator Author

jdegger commented Oct 28, 2020

@fmonsalvo you can open a PR to master directly 👍 any work done by others will just merge master into their work before submitting their PR. Only @fabriziomoscon is currently developing.

Thanks!!

@fabriziomoscon
Copy link
Collaborator

👍 please, to align your branch/forks with master use rebase rather merging as we do want the preserve linear history of master commits.

@benminer
Copy link

@jdegger Just catching up with this! Would love to help once I get some immediate work wrapped up - probably in the coming next few weeks. The app I am building that requires Twilio used to this package before iOS 13 so I would love to switch back to it. When I have some better bandwidth to actually contribute, I will post here. Thanks for the organization of all this!

@jdegger
Copy link
Collaborator Author

jdegger commented Oct 29, 2020

Great @benminer! What kind of contribution can you offer us :)? That way I know who to ping for example PR's to test.

@edzh1
Copy link

edzh1 commented Nov 3, 2020

hey, I can assist with some example app with nodejs backend. also, can update my article https://medium.com/@edzh1/create-a-twilio-voip-calls-in-a-react-native-app-35a729a9613d to reflect changes in the library

@jdegger
Copy link
Collaborator Author

jdegger commented Nov 3, 2020

@edzh1 Wonderful! I have written down your name in the list above. I would suggest you publish it first on your own user and then we can see how we can proceed by maybe moving the repo contents to the hoxfon org for further repo maintenance.

@edzh1
Copy link

edzh1 commented Nov 3, 2020

@jdegger got it, thanks. will try to work on that this weekend

@benminer
Copy link

benminer commented Nov 4, 2020

Great @benminer! What kind of contribution can you offer us :)? That way I know who to ping for example PR's to test.

Very experienced with anything React Native, and moderately experienced with native iOS. Android is my weak spot. Also mainly a backend engineer as my full time gig so if there is anything in that realm, can definitely help out, but since this is a RN package I doubt that is the case 😛

@jdegger
Copy link
Collaborator Author

jdegger commented Nov 5, 2020

@benminer there are some issues which are marked 'backlog'. Those are still available for anybody to work on. Of course you can also propose something else or take one of the items from the begin post here. Let me know :) your enthusiasm is highly appreciated.

@jdegger
Copy link
Collaborator Author

jdegger commented Nov 10, 2020

@edzh1 How is it going 👍? Any progress! Let me know if we can assist.

@edzh1
Copy link

edzh1 commented Nov 10, 2020

@jdegger hey, sorry for the delay, will share results this week

@jdegger
Copy link
Collaborator Author

jdegger commented Nov 10, 2020

@edzh1 absolutely no need to apologize! Just checking in 👍 very happy with all the help we are getting, much appreciated.

Also it goes without saying: take as long as you need!

@edzh1
Copy link

edzh1 commented Nov 15, 2020

@jdegger hey, quick update. app is almost finished, need a couple of days more to polish and write an article about it. will keep you updated

@jdegger
Copy link
Collaborator Author

jdegger commented Nov 16, 2020

Great @edzh1 and thanks for the update. Just so you know @fabriziomoscon is also working on pushing some great upgrades as well (see open PRs).

@edzh1
Copy link

edzh1 commented Nov 20, 2020

@jdegger hey, some news. I've decided to postpone development of an example app a bit. Initially I've been thinking just to update existing example with new modules, but with autolinking my existing article/app doesn't make much sense. My previous example https://github.com/edzh1/react-native-twilio-example-app wasn't very usable, because there was no backend and real calling, I've been more focusing on correct initialization part

This time I've decided, that it's time to create fully featured device to device calling with ability to pick number and etc. It will take much more time that I've planned to spent on this. I will work on this at my spare time, but can't guarantee any deadlines, sorry

@jdegger
Copy link
Collaborator Author

jdegger commented Nov 25, 2020

@jdegger hey, some news. I've decided to postpone development of an example app a bit. Initially I've been thinking just to update existing example with new modules, but with autolinking my existing article/app doesn't make much sense. My previous example https://github.com/edzh1/react-native-twilio-example-app wasn't very usable, because there was no backend and real calling, I've been more focusing on correct initialization part

This time I've decided, that it's time to create fully featured device to device calling with ability to pick number and etc. It will take much more time that I've planned to spent on this. I will work on this at my spare time, but can't guarantee any deadlines, sorry

Thanks for the update @edzh1! No worries, we really appreciate your effort still. We discussed the usefulness of the example app in our meeting and really think it's a great addition.

Might I suggest that you maybe want to start with a small part and maybe I can pitch in with work as well? For example the back-end server can be written in a few hours by me if needed.

@jamesawer3

This comment has been minimized.

@armouti
Copy link

armouti commented Feb 4, 2022

is this library dead?

@Pagebakers
Copy link
Contributor

I'm no longer using it, not sure what the alternatives are.

@calz10
Copy link

calz10 commented Feb 4, 2022

hi I've been using this https://github.com/MrHertal/react-native-twilio-phone and works fine fyi :)

@ZamsolSupportTeam
Copy link

I'm using react-native-twilio-programmable-voice but not able to get twilio incoming call can you please help.

@jdegger jdegger unpinned this issue May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants