Bug: Intervention or Survey not correctly saved when creating them first time

[johannesvedder]

Bug seems to occur on all branches, including main (https://designer.studyu.health)

Steps to reproduce:

• Create a new study
• Give that study a name
• Go to Intervention
• Add a new intervention, modify the title and fill out the description
• Add a intervention task, fill out title
• Save both
• Click on "Unnamed intervention". Neither the intervention title nor the intervention description are saved. Only the task is saved correctly.

The same happens with a new measurement survey. After the bug occured once, it does not happen anymore.

Solution

Seems to be related to https://github.com/hpi-studyu/studyu/blob/dev/designer_v2/lib/features/study/study_test_controller.dart

Removing all occurences of studyTestControllerProvider solves the issue (here and here)

[hig-dev]

Here are the minimal steps to reproduce.

Steps to reproduce:

• Create a new study
• Give that study a name
• Go to Intervention
• Add a new intervention, modify the title
• Save
• Click on "Unnamed intervention". The intervention title is not saved.

I found the root cause for this bug. It has something to do with the instances of InterventionFormViewModel. Multiple instances of InterventionFormViewModel are created and the ReactiveTextField updates instance A, but the save function saves the data from instance B which was not updated. I am investigating this further to find a fix for this bug.

Edit 1:

The two instances of InterventionFormViewModel are created because of:

studyu/designer_v2/lib/features/design/study_form_scaffold.dart

Lines 17 to 34 in 684ef5c

	@override
	Widget build(BuildContext context, WidgetRef ref) {
	final state = ref.watch(studyControllerProvider(studyId));
	// TODO: this architecture results in a 2-stage loading (app init/splash, study)
	// TODO: figure out a way to declare + load data dependencies for routes in one go
	return AsyncValueWidget(
	value: state.study,
	data: (study) {
	final formViewModel = formViewModelBuilder(ref);
	return FormScaffold(
	formViewModel: formViewModel,
	body: formViewBuilder(formViewModel),
	);
	//return formViewBuilder(formViewModel);
	},
	);
	}

)

[hig-dev]

I think this issue is related to joanpablo/reactive_forms#262