Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Examples do not successfully build on older versions of CUDA whereby cuMemAdvise_v2 and cuMemPrefetchAsync_v2 are not present #2331

Closed
br0kej opened this issue Jul 15, 2024 · 3 comments · Fixed by #2332

Comments

@br0kej
Copy link
Contributor

br0kej commented Jul 15, 2024

This has been identified on the upstream cudarc project in this issue with the associated fix in an open PR here. It has not yet been merged yet though.

It's unclear to me what this additional functionality brings and whether it is actually used within Candle. I am happy to open a PR which includes pinning cuadrc to cudarc = { version = "<=0.11.6" } within affected candle-* crates if folks think it's worthwhile.

@LaurentMazare
Copy link
Collaborator

Right, I also add the problem on some of my projects and fixed it by explicitely pinning cudarc in my crates but probably better for users not to have to do this so having the constraint in the main Cargo.toml file sounds good.

@br0kej
Copy link
Contributor Author

br0kej commented Jul 15, 2024

I'll make that change now, run it locally to see if it fixes it and then open the PR 👍🏼

Edit: From looking at the root Cargo.toml, it's pinned already. I am unfamiliar with how version constraints get passed to sub-crates. Does the change need to be applied within each sub-crate Cargo.toml?

@br0kej
Copy link
Contributor Author

br0kej commented Jul 15, 2024

I have opened a PR to resolve this. It was a strange issue as the version was pinned to 0.11.4 but when building Cargo was pulling the latest semver version down anyways. From looking at this stackoverflow post there seems to be some oddness around specifying exact versions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants