[Text-to-video] Update modality #857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
NielsRogge
changed the title
|
|
osanseviero
reviewed
Aug 19, 2024
| @@ -585,7 +585,7 @@ export const PIPELINE_DATA = { | |||
| }, | |||
| "text-to-video": { | |||
| name: "Text-to-Video", | |||
| modality: "cv", | |||
| modality: "multimodal", | |||
There was a problem hiding this comment.
This was done in #477 as part of existing multimodal discussions in Slack (search for this PR). I'm happy to reconsider this specific case
There was a problem hiding this comment.
For me, multimodal is anything that is not single modality
- If only images are involved => cv
- if only text is involed => nlp
- if image + text, or any other combination of modalities (like text and video) => multimodal
There was a problem hiding this comment.
Image generation and captioning involve both text and images. I think the discussion had converged in cardinality of modalities of input or output. Please refer to the existing discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the "text-to-video" task is currently under computer vision, should be multimodal.