Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#16] Encrypt user account for caching #17

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pkdash
Copy link
Member

@pkdash pkdash commented Mar 28, 2024

resolves #16

@pkdash pkdash requested a review from devincowan March 29, 2024 14:55
Copy link

@devincowan devincowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice @pkdash! My only hesitation is thinking about the process as this gets rolled out. If users already have existing user/pw files cached, what will happen?

nbfetch/handlers.py Show resolved Hide resolved
nbfetch/handlers.py Show resolved Hide resolved
@pkdash pkdash marked this pull request as ready for review April 2, 2024 22:28
@pkdash
Copy link
Member Author

pkdash commented Apr 2, 2024

@Castronova Can I merge this?

@pkdash pkdash marked this pull request as draft April 17, 2024 19:46
@pkdash
Copy link
Member Author

pkdash commented Apr 17, 2024

More work to do.

Use a single file to store user information including oauth details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypt user account for caching
2 participants