Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 17 compatibility #31

Open
ismay opened this issue Jun 19, 2021 · 2 comments
Open

React 17 compatibility #31

ismay opened this issue Jun 19, 2021 · 2 comments

Comments

@ismay
Copy link

ismay commented Jun 19, 2021 •
edited
Loading

I'm working on a PR that implements this component, and it works well. However, React 17 isn't allowed with the current peerDependency settings: https://github.com/GraphCMS/react-image/blob/main/package.json#L41-L42

It would be nice if React 17 were allowed as well. From my testing it seems to be compatible.
@fweth
Copy link

fweth commented Feb 13, 2023

Ract 18 would be nice as well :)

@kylekarpack
Copy link

I forked this and released @karpack/react-image here: https://www.npmjs.com/package/@karpack/react-image. It's compatible with React 17 and 18, at least superficially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kylekarpack @ismay @fweth