You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm no expert here but looking at the code there appears to be at least 2 properties which are not covered in the network configuration and there could be more
chainId
privacy
The text was updated successfully, but these errors were encountered:
Hi, @davidkel I went through the code you mentioned ethereum.js which I assume is this and also went through the Ethereum connector docs but I've some doubts. By covering those properties in the documentation. do you simply mean adding a description of those properties in the documentation or is there more to it?
@duckling69 I've not looked into the implementation really (not my area), but noticed that there were properties in the implementation that were not documented. What is really needed is to ensure that the documentation matches the implementation so an understanding of the capabilities of the implementation are required and then the documentation to be adjusted accordingly
I think I got the issue which is inconsistency between docs and implementation.
Can you assign me the issue so I'll start working on it as it may take sometime and will also require some code reviews // @davidkel
I'm no expert here but looking at the code there appears to be at least 2 properties which are not covered in the network configuration and there could be more
The text was updated successfully, but these errors were encountered: