Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcod settings Issuer and Subject(pkix.Name) on TLSCrypto #75

Open
bjwswang opened this issue Nov 9, 2022 · 1 comment
Open

Comments

@bjwswang
Copy link
Contributor

bjwswang commented Nov 9, 2022

When dig into IBPCA reconcile logic, found the TLSCrypto hardcoded Issuer and Subject to IBM. This make tlsroot certficate only can be IBM related settings.


	template := x509.Certificate{
		SerialNumber: serialNumber,
		Issuer: pkix.Name{
			Country:            []string{"US"},
			Province:           []string{"North Carolina"},
			Locality:           []string{"Durham"},
			Organization:       []string{"IBM"},
			OrganizationalUnit: []string{"Blockchain"},
			CommonName:         endpoints.API,
		},
		Subject: pkix.Name{
			Country:            []string{"US"},
			Province:           []string{"North Carolina"},
			Locality:           []string{"Durham"},
			Organization:       []string{"IBM"},
			OrganizationalUnit: []string{"Blockchain"},
			CommonName:         endpoints.API,
		},

		NotBefore: notBefore,
		NotAfter:  notAfter,
	}

https://github.com/hyperledger-labs/fabric-operator/blob/main/pkg/offering/base/ca/ca.go#L785

For people who use fabric-operator on their own products, this is not good.

@bjwswang bjwswang changed the title TLSCrypto has hardcode settings on Issuer and Subject TLSCrypto hardcodedIssuer and Subject to IBM Nov 9, 2022
@bjwswang
Copy link
Contributor Author

bjwswang commented Nov 9, 2022

CSRInfo in pkg/apis/ca/v1/ca.go.CAConfig.Names contains Crypto settings related to pkix.Name,but not working in genTLSCrypto. How about we switch this on?

@bjwswang bjwswang changed the title TLSCrypto hardcodedIssuer and Subject to IBM TLSCrypto hardcodedIssuer and Subject(pkix.Name) to IBM Nov 9, 2022
@bjwswang bjwswang changed the title TLSCrypto hardcodedIssuer and Subject(pkix.Name) to IBM TLSCrypto hardcodedIssuer and Subject(pkix.Name) Nov 9, 2022
@bjwswang bjwswang changed the title TLSCrypto hardcodedIssuer and Subject(pkix.Name) hardcod settings Issuer and Subject(pkix.Name) on TLSCrypto Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant