Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 0454: How to handle Ack messages that have a non OK state? #718

Open
karimStekelenburg opened this issue Feb 6, 2022 · 1 comment
Open

RFC 0454: How to handle Ack messages that have a non OK state? #718

karimStekelenburg opened this issue Feb 6, 2022 · 1 comment
Assignees
@swcurran

Comments

@karimStekelenburg
Copy link

karimStekelenburg commented Feb 6, 2022 •
edited
Loading

Looking at the diagram of 0454 (present-proof-v2) I noticed that whenever an ack message is received, it assumes this message indicates a 'positive acknowledgement'. However 0015 (ack) contains a status field that can be either OK, FAIL or PENDING.

Looking at the diagram of 0454 (present-proof-v2) I get the idea that the verifier only is supposed to send an ack message with an OK status, and otherwise is expected to send a problem-report.

So my question here is, what to do if the verifier sends an ack message with the status set to FAIL?
@TelegramSam
Copy link
Contributor

DIscussed WG 20220316. Should be an ACK-ok, or a Problem Report, not an ACK-fail. Needs explaining text added to relevant RFCs. Also update please-ack decorator. Stephen Curran volunteered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swcurran swcurran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TelegramSam @swcurran @karimStekelenburg