Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] DidDocument type for serviceEndpoint is too strict #1301

Open
gmulhearn opened this issue Nov 19, 2024 · 0 comments
Open

[bug] DidDocument type for serviceEndpoint is too strict #1301

gmulhearn opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working DID

Comments

@gmulhearn
Copy link
Contributor

According to the spec, serviceEndpoint may be a URL string, or a map or set of URLs and/or maps. https://www.w3.org/TR/did-core/#dfn-serviceendpoint

however the current vcx impl has it hardcoded as service_endpoint: Url. We should change it to be an enum of different types.

After this is complete, we may need to also update our did:peer resolvers, as they are known to use this structure in examples for services: https://identity.foundation/peer-did-method-spec/#creating-a-did

@gmulhearn gmulhearn added bug Something isn't working DID labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DID
Projects
None yet
Development

No branches or pull requests

1 participant