Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] did:sov resolver VMs are not correct #1303

Open
gmulhearn-anonyome opened this issue Nov 19, 2024 · 0 comments
Open

[bug] did:sov resolver VMs are not correct #1303

gmulhearn-anonyome opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working DID Resolver DID

Comments

@gmulhearn-anonyome
Copy link
Contributor

gmulhearn-anonyome commented Nov 19, 2024

the current DidSovResolver is only returning 1 VM, #1 and it's only responsibility is "key agreement".

https://sovrin-foundation.github.io/sovrin/spec/did-method-spec-template.html#crud-operation-definitions

The returned VMs should be re-evaluated against the spec. a few notes:

  • #1 should be #key-1
  • #key-1 should be referenced in authentication and assertion lists
  • VMs should also contains #key-agreement-1, which should reference the X25119 version of the #key-1 VM

we should have testing against the spec.

sample obj

DidDocument {
    id: Did {
        did: "did:sov:Dd92jXuEvTerjhTiKnSc27",
        method: Some(
            "sov",
        ),
        id: "Dd92jXuEvTerjhTiKnSc27",
        namespace: None,
    },
    also_known_as: [],
    controller: None,
    verification_method: [
        VerificationMethod {
            id: DidUrl {
                did_url: "#1",
                did: None,
                method: None,
                namespace: None,
                id: None,
                path: None,
                fragment: Some(
                    1..2,
                ),
                queries: {},
            },
            controller: Did {
                did: "did:sov:Dd92jXuEvTerjhTiKnSc27",
                method: Some(
                    "sov",
                ),
                id: "Dd92jXuEvTerjhTiKnSc27",
                namespace: None,
            },
            verification_method_type: Ed25519VerificationKey2018,
            public_key: Base58 {
                public_key_base58: "7t3LhTzn6abJV3HFEwPeKb7gs7K6U4xCUeE4ezHNLcFL",
            },
        },
    ],
    authentication: [],
    assertion_method: [],
    key_agreement: [
        Resolvable(
            DidUrl {
                did_url: "#1",
                did: None,
                method: None,
                namespace: None,
                id: None,
                path: None,
                fragment: Some(
                    1..2,
                ),
                queries: {},
            },
        ),
    ],
    capability_invocation: [],
    capability_delegation: [],
    service: [],
    extra: {},
}
@gmulhearn-anonyome gmulhearn-anonyome added DID Resolver DID bug Something isn't working and removed DID Resolver labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DID Resolver DID
Projects
None yet
Development

No branches or pull requests

1 participant