Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow state override on eth_call and eth_estimateGas #5788

Closed
antonydenyer opened this issue Aug 23, 2023 · 5 comments · Fixed by #7801 or #7890
Closed

Allow state override on eth_call and eth_estimateGas #5788

antonydenyer opened this issue Aug 23, 2023 · 5 comments · Fixed by #7801 or #7890
Assignees
Labels
enhancement New feature or request linea helps L2s using besu mainnet RPC

Comments

@antonydenyer
Copy link
Member

Description

Currently, you can not perform an eth_estimateGas or an eth_call on something that isn't in the 'correct' state as the evm will, correctly, return an error. For example, on an erc20 you may wish to send an approval followed by a transfer call.

You can estimate gas for the approve but not the transfer.
You can not check the result of a transfer without an approval first.

As a network participant, I would like access to be able to drop in and replace Besu in certain networks/tooling/RPC stacks.

Acceptance Criteria

Whilst it's not specified in the ethereum rpc spec the implementation should be based on the Geth rpc docs to allow a drop in replacement.

https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-eth#eth-call

@adarcanum
Copy link

gm, anyone working on this? I recently had to implement this on client side for jvm wouldn't mind submitting a PR for besu.

@antonydenyer
Copy link
Member Author

antonydenyer commented Sep 7, 2023

gm, anyone working on this? I recently had to implement this on client side for jvm wouldn't mind submitting a PR for besu.

I'm not looking at it. I haven't had a chance to finish this!

@macfarla macfarla changed the title Allow state override on eth_call and eth_estimateGas Allow block + state override on eth_call and eth_estimateGas Oct 10, 2024
@macfarla macfarla added the enhancement New feature or request label Oct 10, 2024
@jflo jflo added the linea helps L2s using besu label Oct 14, 2024
@macfarla macfarla self-assigned this Oct 15, 2024
@macfarla macfarla mentioned this issue Oct 23, 2024
8 tasks
@macfarla macfarla changed the title Allow block + state override on eth_call and eth_estimateGas Allow state override on eth_call and eth_estimateGas Oct 29, 2024
@macfarla
Copy link
Contributor

Created new issue for block overrides #7822

@macfarla
Copy link
Contributor

#7801 implements this for eth_call, PR incoming to add the param parsing for eth_estimateGas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linea helps L2s using besu mainnet RPC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants