-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFT Block Puller: unit test the DeliveryRequester #4567
Comments
@tock-ibm I would like to work on this. Is someone working on this? |
Also it seems that the file may have been moved to |
@solo-daemon Thanks for the contribution! I merged your unit tests PR, but see comments here: If you could address these comments in a new PR that would be great. |
@tock-ibm sure I would add another pr shortly. |
@tock-ibm I have added the suggested changes please take a look |
add unit tests for the
internal/pkg/peer/blocksprovider/delivery_requester.go
against a real GRPC service, with security etc.
The text was updated successfully, but these errors were encountered: