Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we introduce a osnadmin channel info subcmd? #4890

Open
yeasy opened this issue Jun 10, 2024 · 7 comments
Open

Should we introduce a osnadmin channel info subcmd? #4890

yeasy opened this issue Jun 10, 2024 · 7 comments
Assignees

Comments

@yeasy
Copy link
Member

yeasy commented Jun 10, 2024

Current Status

osnadmin support following cmds today: join, list and remove.
If we want to get detailed information on specific channel, we use the list cmd with specific channel id.

List channel information for an Ordering Service Node (OSN). If the channelID flag is set, more detailed information will be provided for that channel.

Expected

Another better option is to let list only do list all channels work, and introduce a separate subcmd such as info to do the detailed info query on specific channel.

Solution

Add a new subcmd of info.

Please let us know if you plan to work on this.

Yes!

@Priyansurout
Copy link
Contributor

/assign

@yeasy yeasy self-assigned this Jun 12, 2024
@yeasy
Copy link
Member Author

yeasy commented Jun 12, 2024

@denyeart how do you think?

@Priyansurout
Copy link
Contributor

@yeasy can i also work on this?

@yeasy
Copy link
Member Author

yeasy commented Jun 12, 2024

@yeasy can i also work on this?

Let's wait for @denyeart 's comment first.

@Priyansurout
Copy link
Contributor

ok

@denyeart
Copy link
Contributor

Yes, I agree, osnadmin channel info --channelID=<channel_name> is a good enhancement, we look forward to a contribution!

@Priyansurout
Copy link
Contributor

@yeasy so can i work on this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants