Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to Detect Initial Wallet Balance for Existing Pool #82

Open
onelapahead opened this issue Aug 22, 2022 · 2 comments
Open

Failure to Detect Initial Wallet Balance for Existing Pool #82

onelapahead opened this issue Aug 22, 2022 · 2 comments

Comments

@onelapahead
Copy link
Contributor

onelapahead commented Aug 22, 2022

Using ghcr.io/hyperledger/firefly-tokens-erc20-erc721:v1.0.2 and ghcr.io/hyperledger/firefly:v1.0.3, when creating a pool from an existing ERC20 contract I'm seeing that the wallet was issued the initial pool of tokens has a balance starting from 0 rather than initial supply size:

Screen Shot 2022-08-21 at 8 59 53 PM

As a result, the balance is displayed as a negative sum of all the transfers FireFly observes.

@nguyer
Copy link
Contributor

nguyer commented Jan 19, 2023

Sorry I'm digging up an old issue here @hfuss, but do you recall if you specified the block number to start indexing the token at? I would expect to see this behavior if you choose "newest" rather than "oldest" or the specific block number the contract was deployed in.

@wpater
Copy link

wpater commented Mar 5, 2023

Hello, I have related issue. I used example from this repository for ERC721NoData, deployed it to the Goerli, imported ABI to the FF, registered contract with created interface and address of deployed contract. After this I minted (safeMint function, not via FF GUI) one token to my wallet and created new pool in the FF with interface id, address and block number (block of deployment - 1). After those operations I minted in the same way two different tokens to different wallet.

None of them is displayed in the FF GUI. No transfers, no balances, just empty.

Contract - https://goerli.etherscan.io/address/0x210fa3c575b1a073ff2e475f30a20eca96473352
Code - https://github.com/hyperledger/firefly-tokens-erc20-erc721/blob/main/samples/solidity/contracts/ERC721NoData.sol
Solidity compiler - 0.8.18

Logs from instance:

[Nest] 17  - 03/05/2023, 7:07:57 AM     LOG [RequestLogging] POST /api/v1/createpool RyLo7awU
[Nest] 17  - 03/05/2023, 7:07:57 AM     LOG [TokensService] Create token pool from existing: '0x210FA3c575B1a073FF2E475F30A20eca96473352'
[Nest] 17  - 03/05/2023, 7:07:57 AM     LOG [AbiMapperService] Querying interface '0xaefe69bf' support on contract '0x210FA3c575B1a073FF2E475F30A20eca96473352': false
[Nest] 17  - 03/05/2023, 7:07:57 AM     LOG [AbiMapperService] Querying interface '0x8706707d' support on contract '0x210FA3c575B1a073FF2E475F30A20eca96473352': false
[Nest] 17  - 03/05/2023, 7:07:58 AM     LOG [AbiMapperService] Querying interface '0xb2429c12' support on contract '0x210FA3c575B1a073FF2E475F30A20eca96473352': false
[Nest] 17  - 03/05/2023, 7:07:58 AM     LOG [RequestLogging] POST /api/v1/checkinterface mQPCvGZ4
[Nest] 17  - 03/05/2023, 7:07:58 AM     LOG [RequestLogging] POST /api/v1/activatepool o844n05O
[Nest] 17  - 03/05/2023, 7:07:58 AM     LOG [EventStreamService] Created subscription fft:address=0x210fa3c575b1a073ff2e475f30a20eca96473352&schema=ERC721NoData&type=nonfungible:Approval:default: 0186b099-3e77-f157-9c62-976e5dd1f5c3
[Nest] 17  - 03/05/2023, 7:07:58 AM     LOG [EventStreamService] Created subscription fft:address=0x210fa3c575b1a073ff2e475f30a20eca96473352&schema=ERC721NoData&type=nonfungible:ApprovalForAll:default: 0186b099-3e77-f157-9c62-976e5dd1f5c4
[Nest] 17  - 03/05/2023, 7:07:58 AM     LOG [EventStreamService] Created subscription fft:address=0x210fa3c575b1a073ff2e475f30a20eca96473352&schema=ERC721NoData&type=nonfungible:Transfer:default: 0186b099-3e7c-1dda-7623-233d0e7d901d

My RPC endpoint is working for sure - earlier I was trying to setup some listeners and it was working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants