Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CONTRIBUTING.md commit message requirements match the identus CONTRIBUTING.md? #39

Open
coveloper opened this issue Aug 4, 2024 · 3 comments
Assignees
Labels
triage:query Maintainer is requesting for additional info for the issue in order to continue issue analysis and f

Comments

@coveloper
Copy link

Proposed feature

Suggesting we follow the same commit message requirements as identus: https://github.com/hyperledger/identus/blob/main/CONTRIBUTING.md

Feature description

Maybe we should have one consistent set of instructions on how to contribute across all the Identus repositories. I propose we use the instructions and commit formatting detailed in https://github.com/hyperledger/identus/blob/main/CONTRIBUTING.md

Anything else?

Is there any other technical reason we would need to keep the previous commit message formatting? Is there any automated tooling that would break if the format changes going forward?

@essbante-io essbante-io transferred this issue from hyperledger/identus-edge-agent-sdk-swift Aug 7, 2024
@essbante-io
Copy link
Contributor

Hi, @coveloper. I transferred the issue to the main Identus repo.

@essbante-io essbante-io added the triage:query Maintainer is requesting for additional info for the issue in order to continue issue analysis and f label Aug 7, 2024
@essbante-io
Copy link
Contributor

Hi, @mattklepp, I'm assigning this to you so you can align with the code owners.
Options mentioned during the Mantainers call:

  • Option 1: Match the CONTRIBUTING guidelines in all the repositories
  • Option 2: Code owners of each repo define the scope and guidelines for contributions in their corresponding CONTRIBUTING.md file.
  • Option 3: Something different

@mattklepp
Copy link

Thank you. I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage:query Maintainer is requesting for additional info for the issue in order to continue issue analysis and f
Projects
None yet
Development

No branches or pull requests

6 participants