-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auth_rules document to reflect the current defaults #1755
Comments
The indicated discrepancy in the documentation may actually be a bug in the code. The initial code associated to the above indicated changes happened here, 8d505a9, and is associated with this Jira ticket, https://jira.hyperledger.org/browse/INDY-1554. The acceptance criteria for the ticket (in both settings cases) indicates the owner of the |
First step would be to determine if this particular discrepancy is a bug or intentional. |
@mac-arrap, @VladimirWork, Do either of you recall this work? |
So what I remember is that this went through a lot of review by the evernym team but we didn't change the documentation. But I would feel a lot more comfortable if @ashcherbakov would confirm. |
@mac-arrap, What's throwing me off right now is the acceptance criteria of the jira ticket matches what is indicated in the auth_rules documentation, but it does not match the default auth_rule (included above) that was implemented in the code. |
The Default AUTH_MAP Rules document, although mostly accurate, does not fully reflect the default auth rules of a new indy-node network.
One example is the
REVOC_REG_ENTRY ADD
rule. The document states the owner of the correspondingREVOC_REG_DEF
, regardless of role, can add newREVOC_REG_ENTRY
s. The default auth_rules for the network on the other hand, indicate you need to be the owner of the correspondingREVOC_REG_DEF
and have a signature from a Trustee, Steward, or Endorser.Taken from a new network:
It appears the rule for adding a new
REVOC_REG_ENTRY
was updated in mid 2019, but the documentation was not updated to reflect the change in code.The text was updated successfully, but these errors were encountered: