Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on Android 4.4 #3

Open
hkurokawa opened this issue Feb 16, 2019 · 3 comments
Open

Crashes on Android 4.4 #3

hkurokawa opened this issue Feb 16, 2019 · 3 comments

Comments

@hkurokawa
Copy link

Hi,

I found my app receently built with stetho-no-op crashes on Android 4.4. I am afraid that is because steho-no-op module has a dependency on OkHttp 3.+. As you might already know OkHttp 3.13 drops the support for Android 4.4 and below. So I want to stick to OkHttp 3.12 or below but steho-no-op forces us to use the latest OkHttp, 3.13.1.
https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-3130

My question is what is the rationale behind 3.+ is specified in build.gradle? I am not sure if stetho-no-op always requires the latest OkHttp version. If no, do you agree on fixing the version to 3.12.1?

compile 'com.squareup.okhttp3:okhttp:3.+'

As a workaround, I removed stetho-no-op and it resolved the crashes.

Thanks.

@ivannarino
Copy link

Hi Hiroshi,
You could have done the following as well:

implementation ('net.igenius:stetho-no-op:1.1') {
        exclude group: 'com.squareup.okhttp3', module: 'okhttp'
}
implementation 'com.squareup.okhttp3:okhttp:3.12'

@bluetoothfx
Copy link

@ivannarino thanks for your suggestion, will try.

@CurtesMalteser
Copy link

In fact we aren't targeting API's below 21. So I need to decided with the rest of the team what will do next with the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants