fix url for mobile users #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 27ab6a6 and detected 0 issues on this pull request. View more on Code Climate. |
|
Can you explain what you're trying to address with this PR? |
|
Certainly, without this PR, mobile users are not getting the pop-up box that allows them to enter the url value and display. This pr displays it to mobile users as well.
…On Wed, Dec 20, 2023, at 11:49 AM, Matt Friedman wrote:
Can you explain what you're trying to address with this PR?
—
Reply to this email directly, view it on GitHub <#127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BD5CWRGELTXYRMWPB62GVHLYKMJI3AVCNFSM6AAAAABAKLHYCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUHAYTAMJUGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
This is actually intended behavior on mobile devices, popup modals like that don't always work well, depending on the device, so it's supposed to be the normal bbcode functionality on mobile. That popup is supposed to just be for desktop devices. |
|
I have manually applied this change on a board, and it works very well on current mobile devices. I am not sure where you saw that it does not work well... and the user with such mobile device generally has no idea how to manually apply the bbcode for url correctly.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.