Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese IME sogou,cause crash by editing text before a inline-element #5066

Open
OldDream opened this issue Jul 28, 2022 · 1 comment · May be fixed by #5407
Open

Chinese IME sogou,cause crash by editing text before a inline-element #5066

OldDream opened this issue Jul 28, 2022 · 1 comment · May be fixed by #5407
Labels

Comments

@OldDream
Copy link
Contributor

OldDream commented Jul 28, 2022

Description
Chinese IME sogou,cause crash by editing text before a inline-element.
select -> input by sogou IME -> crash

Recording
rec

Sandbox

This bug can be reproduce with official online demo.
https://www.slatejs.org/examples/mentions

Steps
To reproduce the behavior:

  1. select all characters befor @R2-D2
  2. start input with sogou IME
  3. then the bug show up.
  4. See error in console:
    Uncaught Error: Cannot resolve a Slate point from DOM point: [object Text],2 at Object.toSlatePoint ([example]-5e4f16b701ecada0.js:1:99830) at Object.toSlateRange ([example]-5e4f16b701ecada0.js:1:100498) at HTMLDocument.<anonymous> ([example]-5e4f16b701ecada0.js:1:117948) at g (674-c731382ea76bd727.js:1:1377655) at b (674-c731382ea76bd727.js:1:1377711) at HTMLDocument.z (674-c731382ea76bd727.js:1:1378030) at g (674-c731382ea76bd727.js:1:1377655) at S (674-c731382ea76bd727.js:1:1377930) at w (674-c731382ea76bd727.js:1:1377820)

Context
The official demo can work smooth with Microsoft's chinese IME, so I'm not sure if this is a bug. But sogou IME is widely used in china. So it would be very helpful if we can fix this.

@OldDream OldDream added the bug label Jul 28, 2022
@zbeyens zbeyens linked a pull request Apr 27, 2023 that will close this issue
5 tasks
@washanhanzi
Copy link

#5762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants