Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost effective lodash #5617

Open
nike1v opened this issue Mar 15, 2024 · 3 comments
Open

Cost effective lodash #5617

nike1v opened this issue Mar 15, 2024 · 3 comments
Labels

Comments

@nike1v
Copy link

nike1v commented Mar 15, 2024

Problem
I'm investigating my current project to minimize the bundle size and how much data used for people to load, the only library I have in package that uses ALL lodash library as a package is slate.

Solution
I'd like you to change all lodah imports to splitted modules (they are done not for fun). There are only 23 places where it is used, so it'll be quick fix.

Alternatives
A clear and concise description of any alternative solutions or features you've considered.

Context
If you want me to help you with this, so all slate packages will use effective version of lodash, where used, I can do this via PR. Just let me know, thanks!

@nike1v nike1v added the feature label Mar 15, 2024
@dylans
Copy link
Collaborator

dylans commented Mar 15, 2024

@nike1v I'm happy to review and land a PR for this change.

@christianhg
Copy link

It looks like this is fixed in #4245.

@jamesremuscat
Copy link

It looks like this is fixed in #4245.

That PR was merged nearly three years before OP opened this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants