Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies inclusion from all available bundles #70

Open
drfits opened this issue Oct 17, 2017 · 0 comments
Open

Dependencies inclusion from all available bundles #70

drfits opened this issue Oct 17, 2017 · 0 comments

Comments

@drfits
Copy link

drfits commented Oct 17, 2017

Hello,
we have a multi-module project. Each module contains a set of components(with dialog) and dependencies to other modules. After compilation we have a set of dialogs not only from current module but also from other modules.
To exclude this unwanted dependencies from construction process we can use excludeDependencies but we should maintain this list of exclusions and validate generated dialogs every time for every module after any dependency changes.
To facilitate this process and prevent from generation of unwanted dialogs we can intend includeDependencies option where we could specify dependencies from which we desire to compile dialogs and skip other related dependencies. Pull request with implementation was created here - pull 69.
Description of implementation:

  1. By default if either includeDependencies nor excludeDependencies was omitted construction process consider all compile/provided/system scope dependencies from maven module.
  2. If includeDependencies was specified the construction process will consider components only from specified compile/provided/system scope dependencies.
  3. If excludeDependencies was specified the construction process will consider components within specified compile/provided/system scope dependencies except dependencies specified in excludeDependencies*
  4. If both includeDependencies and excludeDependencies were specified includeDependencies takes priority and excludeDependencies will not be considered by construction process

Thanks for considering this request
@michaelhodgdon @pmichelotti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant