fix(download.ts): set events as PRIVATE by default #1003
Conversation
KevinWu098
requested review from
KevinWu098
and removed request for
Douglas-Hong
There was a problem hiding this comment.
LGTM, thanks for this change! 💪
Before merging though, I'm kind of curious as to what effect this has on a per-user / per-event use case. Just because an event is public visibility, doesn't the calendar which it resides need to be shared? I'm mostly curious as to if there's a specific case where specifying the visibility to private would be important and/or common.
|
@calejvaldez what do you say about @KevinWu098 's question about the utility? If you share your calendar, wouldn't you want the other person to know when you have class by default? It's not like when you have class is any more private than other events on the calendar, right? |
|
@MinhxNguyen7 @KevinWu098 That's true, though my biggest concern was that UCI sets our calendars as shared by default without notifying the user. If we don't specify an event's Unless users specifically go into their Calendar settings and change the default calendar visibility to private, anything they add to their calendar will be shared. In theory, using the default makes sense, though IMO it makes sense if a user is aware their events are public, which the few people I've pointed this out to said they weren't aware. |
|
I think that setting the visibility to the account's default makes sense, regardless of whether that behavior is desired by the user. Put otherwise, it's not our problem. Unless there's substantial opinion otherwise, I'm going to close this for now. Sorry to not take your work, and I appreciate your investigation into this. |
Summary
I opened #963 a few months ago when I noticed that Google Calendar events imported from AntAlmanac were public for anybody with my UCI email to see. This concerned me because this meant people would know exactly where I'd be and when.
This fixes the issue by setting the
classificationattribute toPRIVATEon the events in thecalendarEventsarray, making the event private.Test Plan
I tested this by downloading the
.icsfile using a development environment of AntAlmanac with my changes and importing it to my Google Calendar, and successfully saw that it was a private event by default.... no I'm not taking ICS 6B. I can never go through that again...
Issues
Closes #963