Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mobile Tabs to Bottom #976

Closed
KevinWu098 opened this issue May 4, 2024 · 6 comments · Fixed by #1001
Closed

Move Mobile Tabs to Bottom #976

KevinWu098 opened this issue May 4, 2024 · 6 comments · Fixed by #1001
Labels
enhancement Improvements to the user experience

Comments

@KevinWu098
Copy link
Member

KevinWu098 commented May 4, 2024

I do think that the bar should be at the bottom

Screenshot 2024-05-04 at 12 23 30 PM

Originally posted by @MinhxNguyen7 in #921 (review)

@vinnyho
Copy link
Contributor

vinnyho commented Sep 22, 2024

I will be trying to take this issue.

@KevinWu098
Copy link
Member Author

I will be trying to take this issue.

I believe this one is being worked on in #1001 !

@MinhxNguyen7
Copy link
Member

I will be trying to take this issue.

I believe this one is being worked on in #1001 !

I wouldn't hold my breath, since @ap0nia has graduated. @vinnyho feel free to take the relevant parts of his code to complete this PR.

@MinhxNguyen7 MinhxNguyen7 added enhancement Improvements to the user experience and removed Stale labels Sep 23, 2024
@KevinWu098
Copy link
Member Author

I will be trying to take this issue.

I believe this one is being worked on in #1001 !

I wouldn't hold my breath, since @ap0nia has graduated. @vinnyho feel free to take the relevant parts of his code to complete this PR.

IIRC it's pretty damn close, as far as I can recall

@ap0nia can you confirm? would prefer not to send @vinnyho on the same path if we're close to completion!

@ap0nia
Copy link
Collaborator

ap0nia commented Sep 23, 2024

I believe it should almost be done actually. I addressed the feedback that Kevin left on his review, and I was blocked on nitpicks like the name of components.

I can finish writing up the PR summary and QA testing with Kevin if that's alright.

@vinnyho
Copy link
Contributor

vinnyho commented Sep 23, 2024

Thank you, I will find another issue to try and fix. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the user experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants