Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deflate_* functions were only added on PHP 7 #208

Open
Luc45 opened this issue Sep 14, 2020 · 1 comment
Open

deflate_* functions were only added on PHP 7 #208

Luc45 opened this issue Sep 14, 2020 · 1 comment
Assignees
Labels

Comments

@Luc45
Copy link

Luc45 commented Sep 14, 2020

The CompressGzipstream uses some functions that were only added on PHP 7:

----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 1476 | ERROR | The function deflate_init() is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.FunctionUse.NewFunctions.deflate_initFound)
 1476 | ERROR | The constant "ZLIB_ENCODING_GZIP" is not present in
      |       | PHP version 5.6 or earlier
      |       | (PHPCompatibility.Constants.NewConstants.zlib_encoding_gzipFound)
 1483 | ERROR | The function deflate_add() is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.FunctionUse.NewFunctions.deflate_addFound)
 1483 | ERROR | The constant "ZLIB_NO_FLUSH" is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.Constants.NewConstants.zlib_no_flushFound)
 1492 | ERROR | The function deflate_add() is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.FunctionUse.NewFunctions.deflate_addFound)
 1492 | ERROR | The constant "ZLIB_FINISH" is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.Constants.NewConstants.zlib_finishFound)
----------------------------------------------------------------------
@ifsnop
Copy link
Owner

ifsnop commented Nov 3, 2020

I think we should better rollback this commit. I appreciate backwards compatibility.

@ifsnop ifsnop self-assigned this Nov 3, 2020
@ifsnop ifsnop added the bug label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants