Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instruction to take a look at Code of Conduct and Contribution Guidelines #54

Open
aashutoshrathi opened this issue Oct 4, 2018 · 20 comments
Labels
contribute-a-thon Issues for contribute-a-thon Hacktoberfest Fix to increase your Hacktoberfest PR count

Comments

@aashutoshrathi
Copy link
Member

Add Instruction to take a look at Code of Conduct and Contribution Guidelines on getmein web page, email sent to new member and README too.

@aashutoshrathi aashutoshrathi added the Hacktoberfest Fix to increase your Hacktoberfest PR count label Oct 4, 2018
@Ananthavijay
Copy link
Contributor

screenshot 1

Is this Fine @aashutoshrathi

@nlok5923
Copy link
Member

@iiitv/project-maintainers if this issue is still open i would like to work on it.

@anujpuri72 anujpuri72 added the contribute-a-thon Issues for contribute-a-thon label Sep 21, 2020
@anujpuri72
Copy link
Member

@nlok5923 GFI

@nlok5923
Copy link
Member

@aashutoshrathi sir please can you help me . I am getting an error while committing changes.
Screenshot (1346)

I tried resolving it via some google search but didn't get out of it.

@aashutoshrathi
Copy link
Member Author

Try replacing ./node_modules/eslint/bin/eslint.js with eslint in your package.json, don't commit it for now.

@nlok5923
Copy link
Member

@aashutoshrathi thanks sir it worked out . but sir when to commit those changes then.

@aashutoshrathi
Copy link
Member Author

@iiitv/project-maintainers We need to make separate issue to make changes in package.json, right?

@nlok5923
Copy link
Member

nlok5923 commented Sep 22, 2020

@aashutoshrathi sir if you want i can work on it.

@nlok5923
Copy link
Member

@aashutoshrathi sir I tried to implement the feature and keeping the height 100vh in this manner.
Screenshot (1350)
is it fine sir.

@theyashshahs
Copy link
Member

@nlok5923 also check if your implementation is responsive or not

@nlok5923
Copy link
Member

@yashshah2820 sir i checked the above implementation breaks in some mobile sized view. so i changed it a bit.
Screenshot (1352)

@theyashshahs
Copy link
Member

please provide a testing link for this 🙂

@nlok5923
Copy link
Member

nlok5923 commented Sep 23, 2020

@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/

Portal to get an invite to IIITV Github organization

@theyashshahs
Copy link
Member

theyashshahs commented Sep 23, 2020

@yashshah2820 sir deployment link : https://nlok5923-getmein-web-3.glitch.me/

**Welcome to IIITV**Portal to get an invite to IIITV Github
organization

have you created a PR for these changes?

Portal to get an invite to IIITV Github organization

@nlok5923
Copy link
Member

nlok5923 commented Sep 23, 2020

@yashshah2820 no sir for commiting this changes first the issue #124 should get resolved as this issue not allowing me to commit anything.

@nlok5923
Copy link
Member

nlok5923 commented Sep 23, 2020

can we do this :
@iiitv/project-maintainers sir is it possible that i make pr for resolving this issue by replacing ./node_modules/eslint/bin/eslint.js with eslint in package.json and later on we can resolve #124 .

@aashutoshrathi
Copy link
Member Author

Hey, read more about git add (Surprise, its not only git add .) command and how you can skip committing and staging files.
I think we can get this PR done without touching package.json.

@nlok5923
Copy link
Member

@aashutoshrathi ohh so sorry sir i really forgotten about the same thank you sir

@Ayush-Khandelwal28
Copy link

@iiitv/project-maintainers, I would like to work on the issue.

@AkhileshManda
Copy link
Member

AkhileshManda commented Oct 2, 2022

@iiitv/react-maintainers @Im-Madhur-Gupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute-a-thon Issues for contribute-a-thon Hacktoberfest Fix to increase your Hacktoberfest PR count
Projects
None yet
Development

No branches or pull requests

7 participants