Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to retrieve all tags defined within a file #243

Open
gschulze opened this issue Sep 2, 2024 · 2 comments · May be fixed by #255
Open

Provide a way to retrieve all tags defined within a file #243

gschulze opened this issue Sep 2, 2024 · 2 comments · May be fixed by #255

Comments

@gschulze
Copy link

gschulze commented Sep 2, 2024

Currently, it is only possible to retrieve single tags via get_tag(...) and find_tag(...). However, one might be interested in obtaining all defined tags, for instance, when modifying the TIFF and writing it to a file again. Two possible APIs come to my mind:

  • fn get_all_tags(): impl<Iterator<Item = Tag>>, returning all tags defined in the TIFF file, or
  • fn get_all_tags(): HashMap<Tag, ifd::Value>, returning all tags along with their value

It would be really nice to have this addition.
@gschulze gschulze mentioned this issue Sep 3, 2024
Open
@spoutn1k
Copy link
Contributor

I'm working on #242 to do just that, it is far from ready but I am implementing a newtype over your second proposition to streamline tag access. I can update here once I have a better prototype.

This was referenced Oct 2, 2024
Draft
Open
@gschulze gschulze linked a pull request Nov 20, 2024 that will close this issue
Open
@gschulze
Copy link
Author

I've opened a PR: #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for iterating over all tags gschulze/image-tiff
2 participants
@gschulze @spoutn1k