Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent/limited search results causing confusion #40

Open
gRegorLove opened this issue Jun 26, 2017 · 3 comments
Open

Inconsistent/limited search results causing confusion #40

gRegorLove opened this issue Jun 26, 2017 · 3 comments

Comments

@gRegorLove
Copy link
Member

gRegorLove commented Jun 26, 2017

@dougbeal discovered a search bug and we were able to narrow it down.

From the homepage, searching for a term should return all pages that contain that term in the title or body. For example, searching "rocks" should return the wiki pages https://indieweb.org/Webmention_Rocks and and https://indieweb.org/Micropub_Rocks. Instead it's returning only https://indieweb.org/everything because it contains the word "rocks" in the body. This was making it difficult for him (and I'm sure others) to find pages on the wiki.

There appears to be a difference between the built-in MediaWiki search form at https://indieweb.org/Special:Search (in the main content area) and the search form that appears at the top right. If you search rocks in the top right form, it only shows the more-limited results. If you use the one in the main content area, you get the fuller, expected results. Note that the homepage, where Doug was searching from, only has the more-limited search form.

Debugging the URLs it appears the difference that causes this is the redirs=0 URL param.

Compare:
https://indieweb.org/wiki/index.php?title=Special%3ASearch&redirs=0&search=rocks&fulltext=Search&ns0=1

with:
https://indieweb.org/wiki/index.php?title=Special%3ASearch&search=rocks&fulltext=Search

@sknebel
Copy link
Member

sknebel commented Jun 26, 2017

I added the redirect parameter in https://indieweb.org/wiki/index.php?diff=38154&oldid=37902&rcid=38070 and it now works for me. Please confirm

@gRegorLove
Copy link
Member Author

Thanks, @sknebel! That fixes it on the homepage. On internal pages the top-right search needs to be updated with that as well.

@sknebel
Copy link
Member

sknebel commented Jun 29, 2017

Interesting, I thought I found during testing that that works, but you are right, it doesn't. no idea where to change that though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants