-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 5.1.9 iOS release builds failing on old architecture #1513
Comments
No, it's not using expo. But has been upgraded to the latest version of
react native.
…On Fri, Oct 18, 2024 at 11:07 PM Frank Calise ***@***.***> wrote:
@jerinjohnk <https://github.com/jerinjohnk> are you using Expo Go?
—
Reply to this email directly, view it on GitHub
<#1513 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACV6TGEEI2JBFI46LHIDGOLZ4FBO3AVCNFSM6AAAAABQCID2MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSHE2DGNJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, same issue using the latest version, use the previous version works. |
@TrejoCode are you using new arch or old? |
same here, this link may help facebook/react-native#47193 (comment) |
@jerinjohnk @TrejoCode @khanhvohoangvib does anyone have a repo reproducing this issue? I haven't been able to reproduce it in an Ignite app via |
We're having the same issue on iOS. We reverted to 5.1.8 where it is working good. |
Happening to me on old arch as well and on v5.1.10.
Used EAS: expo run:ios works just fine, but running a internal distribution build on broswerstack fails (on iOS 18). |
Can someone post a reproducible repo link? With instructions on how to run into this? That would be helpful |
Downgrading to 5.1.8 also solved the issue for me. Adding DEV to that if statement did not work for me. |
Again, need more info if we can get it - such as RN version or a repository demonstrating the issue please. |
I have been trying to reproduce it in a minimal repo with reactotron added as a dev dependency but have been unable to reproduce the same error in that build successfully. |
@jerinjohnk Are you saying that you've added it as a dependency (not dev dependency) in the past and that is what failing? Also, feel free to provide a formatted list of dependencies/dev dependencies from the project that is having troubles if unable to reproduce it - that is still helpful. |
No @frankcalise I didnt mean I had added it as dependency. It has always been added as a dev dependency only. Here's my package list
The error thrown in Xcode log is
|
Hey I have the same problem and downgrading to 5.1.8 didn't work (I was in 5.1.9 I didn't tried 5.1.10 yet tho). I do not get any error on metro only this in XCode:
this is my metro logs:
that's it I don't get anything else. No logs, no issues nothing the app crashed after a successful build. my package.json:
my ReactototronConfig.js:
|
@MarlonAEC and you're saying if you remove the dep the build succeeds? Can you show me how you import the config in the other source file? |
For me, the build always succeeds just when it tries to run the app it crashes. This is how I import the config in my App.js:
|
Oh, my bad I thought about your questions and even commented out the |
@MarlonAEC ok let me know if 5.1.10 changes things for you if you could |
Got the same problem on 5.1.10, unfortunately 😔. Is there anything else I could try? |
@MarlonAEC could you try that Reactotron import higher? It should be one of the first things loaded in your app entry point. |
@MarlonAEC the import should be moved to one of the first lines in the entry point of your application. It seems like you have it further down, which is too late. Notice where it is in Ignite: https://github.com/infinitered/ignite/blob/master/boilerplate/app/app.tsx#L13-L18 This is documented here: https://docs.infinite.red/reactotron/quick-start/react-native/#step-3---add-reactotron-to-your-app |
I wonder if this other issue is related: facebook/react-native#47935 I'm kinda in the same scenario, what I'm trying to do is update my app to the latest react native version 0.76. I had to change a lot of things in my code to make this work but so far everything else got resolved, only this issue is blocking me from running my app. |
Ok a quick update I completely removed reactotron from my project and the app is still crashing. I guess that makes clear the problem is not with this library but with react native 0.76. I will keep searching for a solution if I find something I will update this thread |
I'm getting this same issue on my jest tests. Any thoughts?
Note: Downgrading to
Does fix the errors but wondering whats going wrong with the new updates that is causing this |
This solution facebook/react-native#47935 (comment) fixed the bad_function_call error but I got the same issue as you are getting but with a different package tho:
so I think that solutions kinda just mask the problem but all other packages that are expecting the architecture to be ON start to crash as soon you disable it because they probably are expecting the architecture to be on by default on the latest versions of those packages. I'm still exploring some other options but so far no luck. I opened this bug on the package: dcangulo/react-native-pkce-challenge#511 to see if they know about it but I haven't get a response yet |
@MarlonAEC yeah i was thinking the same thing. I'm not sure why this would be getting invoked for my jest tests though. Makes sense for the runtime error |
Describe the bug
After upgrading the package from 5.1.8 to 5.1.9 and creating a release build on iOS, the build is created and installed on the simulator.
But as soon as it opens, it crashes without any error logs.
Xcode reports failed to load the app.
Downgrading it fixes the issue.
"react-native": "0.75.4",
Even though reactotron has been added as a dev dependency with the following check before initialization.
This shouldn't be causing any problems in the release build.
Earlier, I thought it might be as the following file
DevMenu = require("react-native/Libraries/NativeModules/specs/NativeDevMenu")
doesn't get bundled up in the release build.
Reactotron version
5.1.9
EDIT
Using old arch
The text was updated successfully, but these errors were encountered: