Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readfile.read_snap_dim: more tolerant exaction on DATE12 #1208

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

ssharifi1994
Copy link
Contributor

@ssharifi1994 ssharifi1994 commented May 29, 2024

Hello @yunjunz and other fellows,

I'm opening this thread to have your input on the modification of a part of readfile.py. I'm using SNAP to generate the stack; however, it lacks a direct function to ensure that all interferograms are resampled to a common grid across the dataset. I changed my process so every single pair of scenes is first co-registered to a 3rd reference scene then split the stack and maintain the two scenes of interest to proceed with the rest of the process. This changed the structure of the "Abstracted Metadata" of dim files a little bit in the baseline section. See the snippet below and refer to the attached file here for the full file. The first, second and third dates always belong to the reference, master the slave scenes respectively.
image
This obviously triggered an error when prep_snap.py runs. I modified the code in readfile.py as shown below with the track change feature. It runs now and the baseline values as well as dates are identified correctly. I was wondering if anywhere else in this script or other script(s) should be modified accordingly too.

Let me know if I wasn't clear on anything.
Many thanks,
Sohrab

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

Please see comments made on the lines 1900, 1902, and 1908.
Copy link

welcome bot commented May 29, 2024

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

@yunjunz yunjunz changed the title Modification on readfile.py for stack generated by SNAP readfile.read_snap_dim: more tolerant exaction on DATE12 Jul 31, 2024
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ssharifi1994 for the PR. The example *.dim file is very helpful in the testing. I have modified your PR a little bit, and it should pass running on your own dataset as well.

Could you add your note on #1245 as well?

@yunjunz yunjunz merged commit be73ddd into insarlab:main Jul 31, 2024
8 checks passed
Copy link

welcome bot commented Jul 31, 2024

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants